134130 opened a new pull request, #28428:
URL: https://github.com/apache/shardingsphere/pull/28428
Fixes #28421.
Changes proposed in this pull request:
- The "Database name" is ambiguous; It can be DBMS's product name or It's
inner schema's name.
- In normally, we don't call `MySQL` as "DBMS product name" or "DBMS
name". Just "DBMS" is `MySQL`.
- Just `DBMS` is clear.
- Not changing inner field's naming; Since it is already clear that
`DatabaseServer`'s name means DatabaseProduct's name
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] ~I have made corresponding changes to the documentation.~
- [x] ~I have added corresponding unit tests for my changes.~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
