Pace2Car commented on code in PR #27991:
URL: https://github.com/apache/shardingsphere/pull/27991#discussion_r1289491973
##########
infra/datasource/core/src/main/java/org/apache/shardingsphere/infra/datasource/pool/creator/DataSourceReflection.java:
##########
@@ -170,13 +174,15 @@ public void addDefaultDataSourceProperties() {
}
ConnectionProperties connectionProps =
DatabaseTypedSPILoader.getService(ConnectionPropertiesParser.class,
DatabaseTypeFactory.get(jdbcUrl.get())).parse(jdbcUrl.get(), null, null);
Properties queryProps = connectionProps.getQueryProperties();
+ Properties properties = jdbcConnectionProps.get();
Review Comment:
Variable name using `jdbcProps` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
