sandynz commented on code in PR #27524:
URL: https://github.com/apache/shardingsphere/pull/27524#discussion_r1277066179
##########
test/e2e/operation/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/framework/container/compose/DockerContainerComposer.java:
##########
@@ -62,7 +67,14 @@ public DockerContainerComposer(final DatabaseType
databaseType, final String sto
}
for (int i = 0; i < storageContainerCount; i++) {
StorageContainerConfiguration storageContainerConfig;
- int majorVersion = new
DockerImageVersion(storageContainerImage).getMajorVersion();
+ int majorVersion = 0;
+ try {
+ majorVersion = databaseType instanceof MySQLDatabaseType ? new
DockerImageVersion(storageContainerImage).getMajorVersion() : 0;
+ // CHECKSTYLE:OFF
+ } catch (final RuntimeException ignored) {
+ log.warn("Get major version failed from {}, ignored",
storageContainerImage);
+ // CHECKSTYLE:ON
+ }
storageContainerConfig =
StorageContainerConfigurationFactory.newInstance(databaseType, majorVersion);
Review Comment:
If `majorVersion` is just required for MySQL, could we simplify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
