This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new ed67144fed7 Revise #27226 (#27343)
ed67144fed7 is described below
commit ed67144fed7642068c8860f38ab5f0b13fcc59dc
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jul 21 09:59:10 2023 +0800
Revise #27226 (#27343)
---
.../mode/event/NamedRuleItemChangedEventCreatorTest.java | 14 ++++----------
.../mode/event/UniqueRuleItemChangedEventCreatorTest.java | 14 ++++----------
2 files changed, 8 insertions(+), 20 deletions(-)
diff --git
a/mode/api/src/test/java/org/apache/shardingsphere/mode/event/NamedRuleItemChangedEventCreatorTest.java
b/mode/api/src/test/java/org/apache/shardingsphere/mode/event/NamedRuleItemChangedEventCreatorTest.java
index fe554250e90..b1050878d9e 100644
---
a/mode/api/src/test/java/org/apache/shardingsphere/mode/event/NamedRuleItemChangedEventCreatorTest.java
+++
b/mode/api/src/test/java/org/apache/shardingsphere/mode/event/NamedRuleItemChangedEventCreatorTest.java
@@ -20,26 +20,20 @@ package org.apache.shardingsphere.mode.event;
import org.apache.shardingsphere.infra.rule.event.rule.RuleItemChangedEvent;
import
org.apache.shardingsphere.infra.rule.event.rule.alter.AlterNamedRuleItemEvent;
import
org.apache.shardingsphere.infra.rule.event.rule.drop.DropNamedRuleItemEvent;
-import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import static org.hamcrest.CoreMatchers.instanceOf;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
-public class NamedRuleItemChangedEventCreatorTest {
+class NamedRuleItemChangedEventCreatorTest {
- private NamedRuleItemChangedEventCreator eventCreater;
-
- @BeforeEach
- void setup() {
- eventCreater = new NamedRuleItemChangedEventCreator();
- }
+ private final NamedRuleItemChangedEventCreator eventCreator = new
NamedRuleItemChangedEventCreator();
@Test
void assertCreateWithEventTypeAdded() {
DataChangedEvent dataChangedEvent = new DataChangedEvent("test_key",
"test_value", DataChangedEvent.Type.ADDED);
- RuleItemChangedEvent ruleItemChangedEvent =
eventCreater.create("test_db", "test_item", dataChangedEvent,
"test_type_added");
+ RuleItemChangedEvent ruleItemChangedEvent =
eventCreator.create("test_db", "test_item", dataChangedEvent,
"test_type_added");
assertThat(ruleItemChangedEvent,
instanceOf(AlterNamedRuleItemEvent.class));
assertThat(ruleItemChangedEvent.getType(), is("test_type_added"));
}
@@ -47,7 +41,7 @@ public class NamedRuleItemChangedEventCreatorTest {
@Test
void assertCreateWithEventTypeDeleted() {
DataChangedEvent dataChangedEvent = new DataChangedEvent("test_key",
"test_value", DataChangedEvent.Type.DELETED);
- RuleItemChangedEvent ruleItemChangedEvent =
eventCreater.create("test_db", "test_item", dataChangedEvent,
"test_type_deleted");
+ RuleItemChangedEvent ruleItemChangedEvent =
eventCreator.create("test_db", "test_item", dataChangedEvent,
"test_type_deleted");
assertThat(ruleItemChangedEvent,
instanceOf(DropNamedRuleItemEvent.class));
assertThat(ruleItemChangedEvent.getType(), is("test_type_deleted"));
}
diff --git
a/mode/api/src/test/java/org/apache/shardingsphere/mode/event/UniqueRuleItemChangedEventCreatorTest.java
b/mode/api/src/test/java/org/apache/shardingsphere/mode/event/UniqueRuleItemChangedEventCreatorTest.java
index 3672b48320d..818f6ee25a8 100644
---
a/mode/api/src/test/java/org/apache/shardingsphere/mode/event/UniqueRuleItemChangedEventCreatorTest.java
+++
b/mode/api/src/test/java/org/apache/shardingsphere/mode/event/UniqueRuleItemChangedEventCreatorTest.java
@@ -20,26 +20,20 @@ package org.apache.shardingsphere.mode.event;
import org.apache.shardingsphere.infra.rule.event.rule.RuleItemChangedEvent;
import
org.apache.shardingsphere.infra.rule.event.rule.alter.AlterUniqueRuleItemEvent;
import
org.apache.shardingsphere.infra.rule.event.rule.drop.DropUniqueRuleItemEvent;
-import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import static org.hamcrest.CoreMatchers.instanceOf;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
-public class UniqueRuleItemChangedEventCreatorTest {
+class UniqueRuleItemChangedEventCreatorTest {
- private UniqueRuleItemChangedEventCreator eventCreater;
-
- @BeforeEach
- void setup() {
- eventCreater = new UniqueRuleItemChangedEventCreator();
- }
+ private final UniqueRuleItemChangedEventCreator eventCreator = new
UniqueRuleItemChangedEventCreator();
@Test
void assertCreateWithEventTypeAdded() {
DataChangedEvent dataChangedEvent = new DataChangedEvent("test_key",
"test_value", DataChangedEvent.Type.ADDED);
- RuleItemChangedEvent ruleItemChangedEvent =
eventCreater.create("test_db", dataChangedEvent, "test_type_added");
+ RuleItemChangedEvent ruleItemChangedEvent =
eventCreator.create("test_db", dataChangedEvent, "test_type_added");
assertThat(ruleItemChangedEvent,
instanceOf(AlterUniqueRuleItemEvent.class));
assertThat(ruleItemChangedEvent.getType(), is("test_type_added"));
}
@@ -47,7 +41,7 @@ public class UniqueRuleItemChangedEventCreatorTest {
@Test
void assertCreateWithEventTypeDeleted() {
DataChangedEvent dataChangedEvent = new DataChangedEvent("test_key",
"test_value", DataChangedEvent.Type.DELETED);
- RuleItemChangedEvent ruleItemChangedEvent =
eventCreater.create("test_db", dataChangedEvent, "test_type_deleted");
+ RuleItemChangedEvent ruleItemChangedEvent =
eventCreator.create("test_db", dataChangedEvent, "test_type_deleted");
assertThat(ruleItemChangedEvent,
instanceOf(DropUniqueRuleItemEvent.class));
assertThat(ruleItemChangedEvent.getType(), is("test_type_deleted"));
}
