This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e822dafaf08 feat: support Oracle drop sequence statement. (#27215)
e822dafaf08 is described below

commit e822dafaf083e7e4930eb93964111e6111262b78
Author: boyjoy1127 <[email protected]>
AuthorDate: Mon Jul 17 17:24:28 2023 +0800

    feat: support Oracle drop sequence statement. (#27215)
---
 .../src/main/antlr4/imports/oracle/DDLStatement.g4 |  4 ++++
 .../sql/parser/autogen/OracleStatement.g4          |  1 +
 .../statement/type/OracleDDLStatementVisitor.java  |  7 ++++++
 .../oracle/ddl/OracleDropSequenceStatement.java    | 27 ++++++++++++++++++++++
 .../src/main/resources/case/ddl/drop-sequence.xml  |  1 +
 .../resources/sql/supported/ddl/drop-sequence.xml  |  3 ++-
 6 files changed, 42 insertions(+), 1 deletion(-)

diff --git 
a/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4 
b/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
index 7c3d7132887..bb9549cf8da 100644
--- a/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
+++ b/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
@@ -3497,6 +3497,10 @@ dropPluggableDatabase
     : DROP PLUGGABLE DATABASE pdbName ((KEEP | INCLUDING) DATAFILES)?
     ;
 
+dropSequence
+    : DROP SEQUENCE (schemaName DOT_)? sequenceName
+    ;
+
 dropJava
      : DROP JAVA (SOURCE | CLASS | RESOURCE) objectName
      ;
diff --git 
a/parser/sql/dialect/oracle/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/OracleStatement.g4
 
b/parser/sql/dialect/oracle/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/OracleStatement.g4
index 73eb7ee6489..5d555325902 100644
--- 
a/parser/sql/dialect/oracle/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/OracleStatement.g4
+++ 
b/parser/sql/dialect/oracle/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/OracleStatement.g4
@@ -135,6 +135,7 @@ execute
     | dropContext
     | alterResourceCost
     | alterRole
+    | dropSequence
     | dropProfile
     | dropFunction
     | dropCluster
diff --git 
a/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDDLStatementVisitor.java
 
b/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDDLStatementVisitor.java
index 6d33e1f0a5e..4d75eb9e5ae 100644
--- 
a/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDDLStatementVisitor.java
+++ 
b/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDDLStatementVisitor.java
@@ -114,6 +114,7 @@ import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropPl
 import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropProcedureContext;
 import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropRestorePointContext;
 import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropRollbackSegmentContext;
+import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropSequenceContext;
 import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropSynonymContext;
 import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropTableContext;
 import 
org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser.DropTriggerContext;
@@ -246,6 +247,7 @@ import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.Ora
 import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropProfileStatement;
 import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropRestorePointStatement;
 import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropRollbackSegmentStatement;
+import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropSequenceStatement;
 import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropSynonymStatement;
 import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropTableStatement;
 import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropTriggerStatement;
@@ -942,6 +944,11 @@ public final class OracleDDLStatementVisitor extends 
OracleStatementVisitor impl
         return new OracleDropOperatorStatement();
     }
     
+    @Override
+    public ASTNode visitDropSequence(final DropSequenceContext ctx) {
+        return new OracleDropSequenceStatement();
+    }
+    
     @Override
     public ASTNode visitAlterLibrary(final AlterLibraryContext ctx) {
         return new OracleAlterLibraryStatement();
diff --git 
a/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/oracle/ddl/OracleDropSequenceStatement.java
 
b/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/oracle/ddl/OracleDropSequenceStatement.java
new file mode 100644
index 00000000000..458b113506d
--- /dev/null
+++ 
b/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/oracle/ddl/OracleDropSequenceStatement.java
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl;
+
+import 
org.apache.shardingsphere.sql.parser.sql.common.statement.AbstractSQLStatement;
+import 
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.OracleStatement;
+
+/**
+ * Oracle drop sequence statement.
+ */
+public final class OracleDropSequenceStatement extends AbstractSQLStatement 
implements OracleStatement {
+}
diff --git a/test/it/parser/src/main/resources/case/ddl/drop-sequence.xml 
b/test/it/parser/src/main/resources/case/ddl/drop-sequence.xml
index 19366f1d082..9993acf156a 100644
--- a/test/it/parser/src/main/resources/case/ddl/drop-sequence.xml
+++ b/test/it/parser/src/main/resources/case/ddl/drop-sequence.xml
@@ -18,4 +18,5 @@
 
 <sql-parser-test-cases>
     <drop-sequence sql-case-id="drop_sequence" />
+    <drop-sequence sql-case-id="drop_sequence_with_schema" />
 </sql-parser-test-cases>
diff --git 
a/test/it/parser/src/main/resources/sql/supported/ddl/drop-sequence.xml 
b/test/it/parser/src/main/resources/sql/supported/ddl/drop-sequence.xml
index 18b326e0500..fd845a4f9a4 100644
--- a/test/it/parser/src/main/resources/sql/supported/ddl/drop-sequence.xml
+++ b/test/it/parser/src/main/resources/sql/supported/ddl/drop-sequence.xml
@@ -17,5 +17,6 @@
   -->
 
 <sql-cases>
-    <sql-case id="drop_sequence" value="DROP SEQUENCE seq_id" 
db-types="PostgreSQL,openGauss,SQLServer" />
+    <sql-case id="drop_sequence" value="DROP SEQUENCE seq_id" 
db-types="PostgreSQL,openGauss,SQLServer,Oracle" />
+    <sql-case id="drop_sequence_with_schema" value="DROP SEQUENCE 
test_schema.seq" db-types="Oracle" />
 </sql-cases>

Reply via email to