cardigan1008 commented on code in PR #26911:
URL: https://github.com/apache/shardingsphere/pull/26911#discussion_r1262695761
##########
test/it/optimizer/src/test/resources/converter/select-table.xml:
##########
@@ -18,4 +18,8 @@
<sql-node-converter-test-cases>
<test-cases sql-case-id="select_from_with_table" expected-sql="SELECT *
FROM (TABLE `t0`) AS `dt`" db-types="MySQL" />
+ <test-cases sql-case-id="select_not_in_with_single_table"
expected-sql="SELECT * FROM `t_order_item` WHERE `item_id` IS NOT NULL AND
`item_id` NOT IN (?, ?) ORDER BY `item_id`" db-types="MySQL"
sql-case-types="PLACEHOLDER" />
Review Comment:
Thank you for your feedback. I will work on adding tests for PLACEHOLDER as
soon as possible and update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
