[shardingsphere] branch master updated: Fix sonar issue on NewYamlSQLTranslatorRuleConfigurationSwapper (#26407)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 38c6a771b0f Fix sonar issue on 
NewYamlSQLTranslatorRuleConfigurationSwapper (#26407)
38c6a771b0f is described below

commit 38c6a771b0f553aa83be55d73664768ea5b16e57
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sun Jun 18 12:35:29 2023 +0800

    Fix sonar issue on NewYamlSQLTranslatorRuleConfigurationSwapper (#26407)
    
    * Fix sonar issue on CreateBroadcastTableRuleStatementUpdaterTest
    
    * Fix sonar issue on NewYamlSQLTranslatorRuleConfigurationSwapper
---
 .../yaml/swapper/NewYamlSQLTranslatorRuleConfigurationSwapper.java     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/kernel/sql-translator/core/src/main/java/org/apache/shardingsphere/sqltranslator/yaml/swapper/NewYamlSQLTranslatorRuleConfigurationSwapper.java
 
b/kernel/sql-translator/core/src/main/java/org/apache/shardingsphere/sqltranslator/yaml/swapper/NewYamlSQLTranslatorRuleConfigurationSwapper.java
index 0931e498c8d..0fbf711f8e1 100644
--- 
a/kernel/sql-translator/core/src/main/java/org/apache/shardingsphere/sqltranslator/yaml/swapper/NewYamlSQLTranslatorRuleConfigurationSwapper.java
+++ 
b/kernel/sql-translator/core/src/main/java/org/apache/shardingsphere/sqltranslator/yaml/swapper/NewYamlSQLTranslatorRuleConfigurationSwapper.java
@@ -49,7 +49,6 @@ public final class 
NewYamlSQLTranslatorRuleConfigurationSwapper implements NewYa
     
     @Override
     public SQLTranslatorRuleConfiguration swapToObject(final 
Collection<YamlDataNode> dataNodes) {
-        SQLTranslatorRuleConfiguration result = new 
SQLTranslatorRuleConfiguration();
         for (YamlDataNode each : dataNodes) {
             Optional<String> version = 
GlobalRuleNodeConverter.getVersion(getRuleTagName().toLowerCase(), 
each.getKey());
             if (!version.isPresent()) {
@@ -57,7 +56,7 @@ public final class 
NewYamlSQLTranslatorRuleConfigurationSwapper implements NewYa
             }
             return swapToObject(YamlEngine.unmarshal(each.getValue(), 
YamlSQLTranslatorRuleConfiguration.class));
         }
-        return result;
+        return new SQLTranslatorRuleConfiguration();
     }
     
     private SQLTranslatorRuleConfiguration swapToObject(final 
YamlSQLTranslatorRuleConfiguration yamlConfig) {