[shardingsphere] branch master updated: Fix sonar issues of MySQLDataSourceChecker (#25704)

[zhaojinchao]

This is an automated email from the ASF dual-hosted git repository.

zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 56b018dd61d Fix sonar issues of MySQLDataSourceChecker (#25704)
56b018dd61d is described below

commit 56b018dd61d4da78a3bcbf7805a37d4ebc1e3f62
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Tue May 16 19:03:55 2023 +0800

    Fix sonar issues of MySQLDataSourceChecker (#25704)
---
 .../data/pipeline/mysql/check/datasource/MySQLDataSourceChecker.java  | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/datasource/MySQLDataSourceChecker.java
 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/datasource/MySQLDataSourceChecker.java
index d2228cd6fa4..77d6ddc9efb 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/datasource/MySQLDataSourceChecker.java
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/datasource/MySQLDataSourceChecker.java
@@ -47,8 +47,6 @@ public final class MySQLDataSourceChecker extends 
AbstractDataSourceChecker {
     
     private static final Map<String, String> REQUIRED_VARIABLES = new 
HashMap<>(3, 1);
     
-    private static final String BINLOG_ROW_IMAGE = "BINLOG_ROW_IMAGE";
-    
     static {
         REQUIRED_VARIABLES.put("LOG_BIN", "ON");
         REQUIRED_VARIABLES.put("BINLOG_FORMAT", "ROW");
@@ -104,7 +102,7 @@ public final class MySQLDataSourceChecker extends 
AbstractDataSourceChecker {
         try (PreparedStatement preparedStatement = 
connection.prepareStatement(SHOW_VARIABLES_SQL)) {
             preparedStatement.setString(1, key);
             try (ResultSet resultSet = preparedStatement.executeQuery()) {
-                if (resultSet.next() || 
!BINLOG_ROW_IMAGE.equalsIgnoreCase(key)) {
+                if (resultSet.next()) {
                     String actualValue = resultSet.getString(2);
                     
ShardingSpherePreconditions.checkState(toBeCheckedValue.equalsIgnoreCase(actualValue),
                             () -> new 
PrepareJobWithInvalidSourceDataSourceException(key, toBeCheckedValue, 
actualValue));