Pace2Car commented on code in PR #25122:
URL: https://github.com/apache/shardingsphere/pull/25122#discussion_r1163536175
##########
features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/algorithm/keygen/SnowflakeKeyGenerateAlgorithmTest.java:
##########
@@ -232,4 +232,10 @@ void assertSetMaxTolerateTimeDifferenceMilliseconds()
throws ReflectiveOperation
KeyGenerateAlgorithm algorithm =
TypedSPILoader.getService(KeyGenerateAlgorithm.class, "SNOWFLAKE",
PropertiesBuilder.build(new
Property("max-tolerate-time-difference-milliseconds", "1")));
assertThat(((Properties)
Plugins.getMemberAccessor().get(algorithm.getClass().getDeclaredField("props"),
algorithm)).getProperty("max-tolerate-time-difference-milliseconds"), is("1"));
}
+
Review Comment:
Please keep the indentation of the blank line consistent with the previous
line.
##########
features/sharding/plugin/cosid/src/test/java/org/apache/shardingsphere/sharding/cosid/algorithm/keygen/CosIdSnowflakeKeyGenerateAlgorithmTest.java:
##########
@@ -152,4 +152,9 @@ void assertGenerateKeyWhenGreaterThen1023() {
assertThrows(IllegalArgumentException.class, () ->
algorithm.setInstanceContext(new InstanceContext(new
ComputeNodeInstance(mock(InstanceMetaData.class)), new
WorkerIdGeneratorFixture(1024),
new ModeConfiguration("Standalone", null),
mock(ModeContextManager.class), mock(LockContext.class), eventBusContext)));
}
+
Review Comment:
as same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
