anmui commented on PR #24227:
URL: https://github.com/apache/shardingsphere/pull/24227#issuecomment-1439371744
>
private boolean requireOccupyThreadForConnection(final
ConnectionSession connectionSession) {
return
ProxyContext.getInstance().getContextManager().getMetaDataContexts().getMetaData().getProps().<Boolean>getValue(ConfigurationPropertyKey.PROXY_HINT_ENABLED)
||
TransactionType.isDistributedTransaction(connectionSession.getTransactionStatus().getTransactionType());
}
This is the previous code,if `PROXY_HINT_ENABLED` is true,this will return
true
the ExecutorService will build in this way
ConnectionThreadExecutorGroup.getInstance().get(connectionSession.getConnectionId());
// ⚠️Prototype
and we need to delete `PROXY_HINT_ENABLED`,the code is
private boolean requireOccupyThreadForConnection(final ConnectionSession
connectionSession) {
return
TransactionType.isDistributedTransaction(connectionSession.getTransactionStatus().getTransactionType());
}
when `TransactionType` is local,it will return false
the ExecutorService will build in this way
UserExecutorGroup.getInstance().getExecutorService(); // ⚠️Singleton
when E2E test,it will failed,because connect close 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
