sandynz commented on code in PR #24026:
URL: https://github.com/apache/shardingsphere/pull/24026#discussion_r1098116551
##########
test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/task/PostgreSQLIncrementTask.java:
##########
@@ -73,8 +73,9 @@ public void run() {
private Object insertOrder() {
ThreadLocalRandom random = ThreadLocalRandom.current();
String status = 0 == random.nextInt() % 2 ? null : "中文测试";
- Object[] orderInsertDate = new
Object[]{KEY_GENERATE_ALGORITHM.generateKey(), random.nextInt(0, 6), status,
PipelineCaseHelper.generateJsonString(2)};
- String insertSQL = String.format("INSERT INTO %s
(order_id,user_id,status,t_json) VALUES (?, ?, ?, ?)",
getTableNameWithSchema(orderTableName));
+ String jsonString = PipelineCaseHelper.generateJsonString(2);
+ Object[] orderInsertDate = new
Object[]{KEY_GENERATE_ALGORITHM.generateKey(), random.nextInt(0, 6), status,
jsonString, jsonString.getBytes()};
Review Comment:
1, `jsonString.getBytes()`, could we support Unicode character?
2, It's better to make `PipelineCaseHelper.generateJsonString(2)` could
generate Unicode characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
