zhfeng commented on PR #20008: URL: https://github.com/apache/shardingsphere/pull/20008#issuecomment-1380375088
Thanks @linghengqian and it makes sense to add `<release>8</release>`. Also it should make sure only run `antlr-maven-plugin` in profile which `jdk.version is [11,)`. I suppose that `antlr-maven-plugin` has a propery `antlr.skip` but it doesn't. So it might be useful to raise to add it in `antlr`. And it will add a step in `ci.yml` to just run all the unit tests on `JDK 8` to make sure we don't break anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
