vikiuvb opened a new pull request, #22857: URL: https://github.com/apache/shardingsphere/pull/22857
Fixes #[2826](https://github.com/apache/shardingsphere/issues/2826). Changes proposed in this pull request: - Refactored the ShardingConditionEngineFactory and made it pluggable. It would allow the implementers to override the ShardingConditionEngine implementation based on their business use case, and it also aligns more in terms of the "pluggable" goal of ShardingSphere. If we don't override the implementation, it will fall back to DefaultShardingConditionEngine.java. --- Before committing this PR, I'm sure that I have checked the following options: - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project. - [ ] I have self-reviewed the commit code. - [ ] I have (or in comment I request) added corresponding labels for the pull request. - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. - [ ] I have made corresponding changes to the documentation. - [ ] I have added corresponding unit tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
