This is an automated email from the ASF dual-hosted git repository. jianglongtao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push: new 69792f7656f Remove unused inner class EmptyTableRuleSegment (#22316) 69792f7656f is described below commit 69792f7656f657b495c5ea288b1ea7930d517ba5 Author: ChenJiaHao <37339007+pace2...@users.noreply.github.com> AuthorDate: Tue Nov 22 19:07:35 2022 +0800 Remove unused inner class EmptyTableRuleSegment (#22316) --- .../distsql/parser/core/ShardingDistSQLStatementVisitor.java | 5 ++--- .../distsql/parser/segment/table/AbstractTableRuleSegment.java | 10 ---------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java b/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java index 4de01cfe5db..af9b8590d40 100644 --- a/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java +++ b/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java @@ -81,7 +81,6 @@ import org.apache.shardingsphere.sharding.distsql.parser.segment.strategy.KeyGen import org.apache.shardingsphere.sharding.distsql.parser.segment.strategy.ShardingAuditorSegment; import org.apache.shardingsphere.sharding.distsql.parser.segment.strategy.ShardingStrategySegment; import org.apache.shardingsphere.sharding.distsql.parser.segment.table.AbstractTableRuleSegment; -import org.apache.shardingsphere.sharding.distsql.parser.segment.table.AbstractTableRuleSegment.EmptyTableRuleSegment; import org.apache.shardingsphere.sharding.distsql.parser.segment.table.AutoTableRuleSegment; import org.apache.shardingsphere.sharding.distsql.parser.segment.table.TableReferenceRuleSegment; import org.apache.shardingsphere.sharding.distsql.parser.segment.table.TableRuleSegment; @@ -145,7 +144,7 @@ public final class ShardingDistSQLStatementVisitor extends ShardingDistSQLStatem public ASTNode visitCreateShardingTableRule(final CreateShardingTableRuleContext ctx) { Collection<AbstractTableRuleSegment> tableRuleSegments = ctx.shardingTableRuleDefinition().stream() .map(each -> (AbstractTableRuleSegment) visit(each)).filter(Objects::nonNull).collect(Collectors.toList()); - return tableRuleSegments.isEmpty() ? new EmptyTableRuleSegment() : new CreateShardingTableRuleStatement(tableRuleSegments); + return new CreateShardingTableRuleStatement(tableRuleSegments); } @Override @@ -167,7 +166,7 @@ public final class ShardingDistSQLStatementVisitor extends ShardingDistSQLStatem public ASTNode visitAlterShardingTableRule(final AlterShardingTableRuleContext ctx) { List<AbstractTableRuleSegment> tableRuleSegments = ctx.shardingTableRuleDefinition().stream() .map(each -> (AbstractTableRuleSegment) visit(each)).filter(Objects::nonNull).collect(Collectors.toList()); - return tableRuleSegments.isEmpty() ? new EmptyTableRuleSegment() : new AlterShardingTableRuleStatement(tableRuleSegments); + return new AlterShardingTableRuleStatement(tableRuleSegments); } @Override diff --git a/features/sharding/distsql/statement/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/segment/table/AbstractTableRuleSegment.java b/features/sharding/distsql/statement/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/segment/table/AbstractTableRuleSegment.java index 31073208ede..6821f835c88 100644 --- a/features/sharding/distsql/statement/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/segment/table/AbstractTableRuleSegment.java +++ b/features/sharding/distsql/statement/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/segment/table/AbstractTableRuleSegment.java @@ -43,14 +43,4 @@ public abstract class AbstractTableRuleSegment implements ASTNode { private KeyGenerateStrategySegment keyGenerateStrategySegment; private AuditStrategySegment auditStrategySegment; - - /** - * Empty table rule segment. - */ - public static class EmptyTableRuleSegment extends AbstractTableRuleSegment { - - public EmptyTableRuleSegment() { - super(null, null); - } - } }