RaigorJiang commented on code in PR #21699:
URL: https://github.com/apache/shardingsphere/pull/21699#discussion_r1002720205
##########
features/readwrite-splitting/distsql/parser/src/main/antlr4/imports/readwrite-splitting/RALStatement.g4:
##########
@@ -31,16 +31,12 @@ clearReadwriteSplittingHint
: CLEAR READWRITE_SPLITTING HINT
;
-enableReadDataSource
- : ENABLE READWRITE_SPLITTING (READ)? resourceName (FROM databaseName)?
+alterReadwriteSplittingRuleStatus
+ : ALTER READWRITE_SPLITTING RULE (groupName)? (ENABLE | DISABLE)
resourceName (FROM databaseName)?
Review Comment:
I suggest that groupName is not optional, the user should be clear which
rule they are modifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
