[shardingsphere] branch master updated: [Issue #21021]-Improve coverage of SQLParserRuleQueryResultSet (#21307)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 69689bab6d7 [Issue #21021]-Improve coverage of 
SQLParserRuleQueryResultSet (#21307)
69689bab6d7 is described below

commit 69689bab6d7deb0f23996bf0ae81af3d011b537e
Author: Abhinav Koppula <abhinav.kopp...@gmail.com>
AuthorDate: Mon Oct 3 10:49:49 2022 +0530

    [Issue #21021]-Improve coverage of SQLParserRuleQueryResultSet (#21307)
---
 .../handler/query/SQLParserRuleQueryResultSetTest.java    | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git 
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-distsql/shardingsphere-parser-distsql-handler/src/test/java/org/apache/shardingsphere/parser/distsql/handler/query/SQLParserRuleQueryResultSetTest.java
 
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-distsql/shardingsphere-parser-distsql-handler/src/test/java/org/apache/shardingsphere/parser/distsql/handler/query/SQLParserRuleQueryResultSetTest.java
index 6a5d6921848..d416be9bfa3 100644
--- 
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-distsql/shardingsphere-parser-distsql-handler/src/test/java/org/apache/shardingsphere/parser/distsql/handler/query/SQLParserRuleQueryResultSetTest.java
+++ 
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-distsql/shardingsphere-parser-distsql-handler/src/test/java/org/apache/shardingsphere/parser/distsql/handler/query/SQLParserRuleQueryResultSetTest.java
@@ -17,6 +17,7 @@
 
 package org.apache.shardingsphere.parser.distsql.handler.query;
 
+import java.util.Arrays;
 import 
org.apache.shardingsphere.infra.metadata.database.rule.ShardingSphereRuleMetaData;
 import org.apache.shardingsphere.parser.config.SQLParserRuleConfiguration;
 import 
org.apache.shardingsphere.parser.distsql.parser.statement.queryable.ShowSQLParserRuleStatement;
@@ -31,6 +32,8 @@ import java.util.Optional;
 import static org.hamcrest.CoreMatchers.containsString;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -41,11 +44,13 @@ public final class SQLParserRuleQueryResultSetTest {
         ShardingSphereRuleMetaData ruleMetaData = mockGlobalRuleMetaData();
         SQLParserRuleQueryResultSet resultSet = new 
SQLParserRuleQueryResultSet();
         resultSet.init(ruleMetaData, mock(ShowSQLParserRuleStatement.class));
+        assertTrue(resultSet.next());
         Collection<Object> actual = resultSet.getRowData();
         assertThat(actual.size(), is(3));
         Iterator<Object> rowData = actual.iterator();
         assertThat(rowData.next(), is(Boolean.TRUE.toString()));
         String parseTreeCache = (String) rowData.next();
+        assertFalse(resultSet.next());
         assertThat(parseTreeCache, containsString("initialCapacity: 128"));
         assertThat(parseTreeCache, containsString("maximumSize: 1024"));
         String sqlStatementCache = (String) rowData.next();
@@ -53,6 +58,16 @@ public final class SQLParserRuleQueryResultSetTest {
         assertThat(sqlStatementCache, containsString("maximumSize: 65535"));
     }
     
+    @Test
+    public void assertGetColumnNames() {
+        assertThat(new SQLParserRuleQueryResultSet().getColumnNames(), 
is(Arrays.asList("sql_comment_parse_enable", "parse_tree_cache", 
"sql_statement_cache")));
+    }
+    
+    @Test
+    public void assertGetType() {
+        assertThat(new SQLParserRuleQueryResultSet().getType(), 
is(ShowSQLParserRuleStatement.class.getName()));
+    }
+    
     private ShardingSphereRuleMetaData mockGlobalRuleMetaData() {
         SQLParserRule sqlParserRule = mock(SQLParserRule.class);
         
when(sqlParserRule.getConfiguration()).thenReturn(createSQLParserRuleConfiguration());