sandynz commented on code in PR #20996:
URL: https://github.com/apache/shardingsphere/pull/20996#discussion_r971671887
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/compose/DockerContainerComposer.java:
##########
@@ -50,8 +54,12 @@ public final class DockerContainerComposer extends
BaseContainerComposer {
public DockerContainerComposer(final DatabaseType databaseType, final
String storageContainerImage) {
this.databaseType = databaseType;
governanceContainer = getContainers().registerContainer(new
ZookeeperContainer());
+ StorageContainerConfiguration storageContainerConfig =
StorageContainerConfigurationFactory.newInstance(databaseType);
+ if (DatabaseTypeUtil.isMySQL(databaseType) && new
DockerImageVersion(storageContainerImage).getMajorVersion() > 5) {
+ storageContainerConfig =
ScalingMySQL8ContainerConfigurationFactory.newInstance();
+ }
Review Comment:
Maybe we need to refactor `MySQLContainerConfigurationFactory` as builder
pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
