sandynz commented on code in PR #20944:
URL: https://github.com/apache/shardingsphere/pull/20944#discussion_r969503529
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobPreparer.java:
##########
@@ -143,8 +145,12 @@ private void prepareTarget(final MigrationJobItemContext
jobItemContext) throws
}
private void initInventoryTasks(final MigrationJobItemContext
jobItemContext) {
+ InventoryDumperConfiguration inventoryDumperConfiguration = new
InventoryDumperConfiguration(jobItemContext.getTaskConfig().getDumperConfig());
Review Comment:
`inventoryDumperConfiguration` could be `inventoryDumperConfig` or
`dumperConfig`
##########
shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/api/impl/MigrationJobAPIImplTest.java:
##########
@@ -78,7 +81,7 @@ public static void beforeClass() {
jobAPI = MigrationJobAPIFactory.getInstance();
Map<String, Object> props = new HashMap<>();
// TODO if resource availability is checked, then it should not work
- props.put("jdbcUrl", "jdbc:mysql://localhost:3306/test");
+ props.put("jdbcUrl",
"jdbc:h2:mem:test_ds_0;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MySQL");
Review Comment:
TODO could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
