terrymanu commented on code in PR #20139: URL: https://github.com/apache/shardingsphere/pull/20139#discussion_r945117660
########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/adapter/config/ProxyClusterContainerConfigurationFactory.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config; + +import java.util.HashMap; +import java.util.Map; + +/** + * Proxy cluster container configuration creator. + */ +public final class ProxyClusterContainerConfigurationFactory { Review Comment: Please add private no argument constructor to avoid static class initialize. ########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/container/config/SuiteProxyClusterContainerConfigurationFactory.java: ########## @@ -15,27 +15,30 @@ * limitations under the License. */ -package org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.impl; +package org.apache.shardingsphere.test.integration.container.config; import org.apache.shardingsphere.infra.database.type.DatabaseType; import org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.AdaptorContainerConfiguration; -import java.util.Collections; import java.util.HashMap; import java.util.Map; /** - * Proxy cluster container configuration. + * Suite proxy cluster container configuration creator. */ -public final class DefaultProxyClusterContainerConfiguration implements AdaptorContainerConfiguration { +public final class SuiteProxyClusterContainerConfigurationFactory { - @Override - public Map<String, String> getWaitStrategyInfo() { - return Collections.singletonMap("dataSourceName", ""); + /** + * Creator adaptor container config. Review Comment: please do not use abbreviation for javadoc ########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/container/config/SuiteProxyClusterContainerConfigurationFactory.java: ########## @@ -15,27 +15,30 @@ * limitations under the License. */ -package org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.impl; +package org.apache.shardingsphere.test.integration.container.config; import org.apache.shardingsphere.infra.database.type.DatabaseType; import org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.AdaptorContainerConfiguration; -import java.util.Collections; import java.util.HashMap; import java.util.Map; /** - * Proxy cluster container configuration. + * Suite proxy cluster container configuration creator. */ -public final class DefaultProxyClusterContainerConfiguration implements AdaptorContainerConfiguration { +public final class SuiteProxyClusterContainerConfigurationFactory { - @Override - public Map<String, String> getWaitStrategyInfo() { - return Collections.singletonMap("dataSourceName", ""); + /** + * Creator adaptor container config. Review Comment: Please leave a blank line ########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/container/config/SuiteProxyClusterContainerConfigurationFactory.java: ########## @@ -15,27 +15,30 @@ * limitations under the License. */ -package org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.impl; +package org.apache.shardingsphere.test.integration.container.config; import org.apache.shardingsphere.infra.database.type.DatabaseType; import org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.AdaptorContainerConfiguration; -import java.util.Collections; import java.util.HashMap; import java.util.Map; /** - * Proxy cluster container configuration. + * Suite proxy cluster container configuration creator. */ -public final class DefaultProxyClusterContainerConfiguration implements AdaptorContainerConfiguration { +public final class SuiteProxyClusterContainerConfigurationFactory { - @Override - public Map<String, String> getWaitStrategyInfo() { - return Collections.singletonMap("dataSourceName", ""); + /** + * Creator adaptor container config. Review Comment: Creator is non, please use verb ########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/container/config/SuiteProxyClusterContainerConfigurationFactory.java: ########## @@ -15,27 +15,30 @@ * limitations under the License. */ -package org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.impl; +package org.apache.shardingsphere.test.integration.container.config; import org.apache.shardingsphere.infra.database.type.DatabaseType; import org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.AdaptorContainerConfiguration; -import java.util.Collections; import java.util.HashMap; import java.util.Map; /** - * Proxy cluster container configuration. + * Suite proxy cluster container configuration creator. */ -public final class DefaultProxyClusterContainerConfiguration implements AdaptorContainerConfiguration { +public final class SuiteProxyClusterContainerConfigurationFactory { Review Comment: Please add private no argument constructor to avoid static class initialize. ########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/container/config/SuiteProxyClusterContainerConfigurationFactory.java: ########## @@ -15,27 +15,30 @@ * limitations under the License. */ -package org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.impl; +package org.apache.shardingsphere.test.integration.container.config; import org.apache.shardingsphere.infra.database.type.DatabaseType; import org.apache.shardingsphere.test.integration.env.container.atomic.adapter.config.AdaptorContainerConfiguration; -import java.util.Collections; import java.util.HashMap; import java.util.Map; /** - * Proxy cluster container configuration. + * Suite proxy cluster container configuration creator. Review Comment: Please change the java doc, the class name is factory, but javadoc is creator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
