jrudolph commented on PR #961: URL: https://github.com/apache/pekko-http/pull/961#issuecomment-3950090474
I'd say the test failures are somewhat legit. Right now these kind of parsing errors are all treated with a 400 Bad Request response. However, the cases flagged by the test are all cases of transport/protocol style errors that a valid client should not make (wrong-pseudo headers, illegal usage of `TE`). So, there's a case to be made to answer these with a RST_STREAM(PROTOCOL_ERROR). Usually, 400 responses are used for application level header / request problems less than for transport layer problems (basically, the client application now gets a nice error message but cannot do anything about it because the client library is broken). Not terribly important, so could also make sense to list the failing tests as pending and create an issue to look into changing the behavior for these particular cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
