raboof commented on PR #1379: URL: https://github.com/apache/pekko-connectors/pull/1379#issuecomment-3840640332
The difference appears to be the update of guava: the `reload plugins` classpath seems to have `guava-33.3.1-android.jar` on main and `guava-33.5.0-android.jar` on this branch. Indeed adding `libraryDependencies += "com.google.guava" % "guava" % "33.5.0-android"` to `project/plugins.sbt` introduces this behavior on the main branch as well. So the question becomes: is this change in behavior a bug or a fix for previously-bad behaviour? If I switch to `libraryDependencies += "com.google.googlejavaformat" % "google-java-format" % "1.33.0"` then it stops rewriting the imports again, which I *think* suggests that is the 'intended' behavior(?). So I think short term we could `libraryDependencies += "com.google.googlejavaformat" % "google-java-format" % "1.33.0"`. Longer-term we could help sbt-java-formatter update, work on that has been ongoing in https://github.com/sbt/sbt-java-formatter/pull/223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
