mdedetrich commented on PR #2555: URL: https://github.com/apache/pekko/pull/2555#issuecomment-3649855738
> -1 from me - this is not a a permanent block - but I'm in the middle of a release and would prefer not to have this merged during a release > > I would also like to maybe bring this to a vote of the PMC because I don't really see why we need to deprecate this - we already have javadoc mentioned Source.completionStage. > > I don't see why this method offends anyone. My view is that let users use this if they like it. > can we go down the route of deprecating now (main and 1.5.x) and coming back in a few months and looking at removing from main? This doesn't make sense, if anything we should deprecate the methods as soon as possible, not later. Also lets put things into perspective here, we have been deprecating these `Future` related methods in Java dsl since Pekko 1.2? (maybe 1.3) and unless I missed something there hasn't been a single user complaint. So to me, as far as I can tell, there hasn't been a single actual Java user (of which there are many of, if not more than Scala) that has complained about these methods being deprecated, likely because almost no one in Java is actively trying to use Future. And if for some reason Java users need to use Scala's `Future` in their API, in Scala 2.13 and later there is a method in Scala's stdlib which will convert a Scala `Future` to a Java `CompletionStage`, see [`scala.jdk.javaapi.FutureConverters`](https://www.scala-lang.org/api/current/scala/jdk/javaapi/FutureConverters$.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
