samueleresca commented on PR #391: URL: https://github.com/apache/pekko-persistence-jdbc/pull/391#issuecomment-3648528353
> > > What does everyone think? I added a disclaimer to the migration script and I intend to highlight the fact the scripts are an indicative example in the release notes. This is the last thing I want to get into 1.2.0 before proceeding to a vote on an RC. > > > > > > Is there a way we can verify these scripts through testing them? > > * The sql server script is tested in the CI build. > * The oracle ones are one liners > * the mysql/mariadb ones are not idempotent so are not easy to CI test but they are basically subsets of the full scripts - the subset being the new parts that were added to the scripts for this release Added MariaDB and MySql executions in [this commit](https://github.com/apache/pekko-persistence-jdbc/pull/403/changes/6d8d8f35b15add8f2320af009a30b3c74661a272) Otherwise looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
