pjfanning commented on code in PR #2409: URL: https://github.com/apache/pekko/pull/2409#discussion_r2577498059
########## actor/src/main/java/org/apache/pekko/io/ByteBufferCleaner.java: ########## @@ -36,7 +37,8 @@ * * <p>See <a href=https://bugs.openjdk.java.net/browse/JDK-4724038>JDK-4724038</a> */ -final class ByteBufferCleaner { +@InternalStableApi Review Comment: * this code doesn't fail if Unsafe is not accessible - it accepts that GC will eventually clean but it is better for users if this Unsafe code cleans the instance earlier * it's one of those areas where the Java team keep telling us to stop using Unsafe but in this case, they have not yet given an alternative -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
