mdedetrich commented on PR #546: URL: https://github.com/apache/pekko-management/pull/546#issuecomment-3560403511
> * I can't find any docs that describe the overlap behaviour of old and new tokens. > * I don't think that the 401 retries have a downside. I would keep the code. It may be justifiable to reduce the default max-attempts to 0 or some slightly higher value like 1 or 2. Little reason to go for a default value like 5. I would favour a value like 2. > * I don't see a real benefit to failing fast on a 401. Fair enough, I am going to go ahead and merge this and will follow up with a cherry pick for 1.2.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
