pjfanning commented on code in PR #365: URL: https://github.com/apache/pekko-persistence-jdbc/pull/365#discussion_r2527980212
########## scripts/mariadb-cli.sh: ########## @@ -0,0 +1,4 @@ +#!/bin/bash Review Comment: Can you put an apache source header on this? I know existing ones don't but that's complicated. New stuff should have Apache license headers. ########## core/src/main/scala/org/apache/pekko/persistence/jdbc/state/DurableStateQueries.scala: ########## @@ -15,6 +15,7 @@ package org.apache.pekko.persistence.jdbc.state import org.apache.pekko +import org.apache.pekko.persistence.jdbc.db.MariaDBProfile Review Comment: omit the org.apache bit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
