migesok opened a new pull request, #2477: URL: https://github.com/apache/pekko/pull/2477
Follow up to this discussion: https://github.com/apache/pekko/issues/2026#issuecomment-3501310771 This fixes a random test failure when the global dispatcher used as a persistence plugin dispatcher. This change should unblock https://github.com/apache/pekko/pull/2434 Also adjusted wording changes for write-response-global-order from https://github.com/apache/pekko/pull/2437 The fix explanation: The test relied on an ordering guarantee which wasn't really there. Even though asyncWriteMessages promises were completed in some particular order, AsyncWriteJournal sent out messages in an onComplete callback scheduled on the actor dispatcher, yielding random message order. The test failure shouldn't be a problem for production, non-test, Pekko code, because nothing there relies on write response ordering guarantees between independent persistent actors. And for an individual persistent actor writes - the persistent actor implementation internals handle ordering there correctly regardless of the plugin response ordering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
