mdedetrich commented on PR #2464: URL: https://github.com/apache/pekko/pull/2464#issuecomment-3508012228
> seems generally ok but a couple of regression tests would be useful Regression tests would be pointless because its a case of if it compiles then it works, its just that I have split this PR out of the main work I am doing as part of zstd. We know that this code works as it was directly copied from pekko-http and its working locally with my zstd work To put it differently, once other code starts using this code we know it will work because of that other work being able to compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
