mdedetrich commented on PR #2409:
URL: https://github.com/apache/pekko/pull/2409#issuecomment-3461271807
I have just added another commit where we use the `ByteBufferCleaner` to
clean up the direct byte buffers rather than resorting to GC. There is an open
question about whether we should do
```scala
if (ByteBufferCleaner.isSupported)
ByteBufferCleaner.clean(inputBB)
```
on the `compress` method in `ZstdCompressor` as this will trigger a cleanup
on every `onPush` of the stream. I don't know how expensive this cleanup is,
there can be an argument that for this specific case we should defer it for GC
as GC cleaning up many ByteBuffers as a batch would be faster, @jrudolph can
you comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
