pjfanning commented on code in PR #1976:
URL: https://github.com/apache/pekko/pull/1976#discussion_r2243089433
##########
actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/jfr/Events.scala:
##########
@@ -96,7 +96,7 @@ final class DeliveryProducerReceived(val producerId: String,
val currentSeqNr: L
@StackTrace(false)
@Category(Array("Pekko", "Delivery", "ProducerController")) @Label(
"Delivery ProducerController received demand request")
-final class DeliveryProducerReceivedRequest(val producerId: String, val
requestedSeqNr: Long, confirmedSeqNr: Long)
+final class DeliveryProducerReceivedRequest(val producerId: String, val
requestedSeqNr: Long, val confirmedSeqNr: Long)
Review Comment:
* now that the source has moved to main dir - more checks are done - and
this field is treated as unused
* seems best to make it a val like all the other fields - exposing it to
users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
