pjfanning commented on code in PR #1975:
URL: https://github.com/apache/pekko/pull/1975#discussion_r2242823912
##########
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##########
@@ -30,15 +28,12 @@ object ForkJoinExecutorConfigurator {
final class PekkoForkJoinPool(
parallelism: Int,
threadFactory: ForkJoinPool.ForkJoinWorkerThreadFactory,
+ maximumPoolSize: Int,
unhandledExceptionHandler: Thread.UncaughtExceptionHandler,
asyncMode: Boolean)
- extends ForkJoinPool(parallelism, threadFactory,
unhandledExceptionHandler, asyncMode)
+ extends ForkJoinPool(parallelism, threadFactory,
unhandledExceptionHandler, asyncMode,
+ 0, maximumPoolSize, 1, null,
ForkJoinPoolConstants.DefaultKeepAliveMillis, TimeUnit.MILLISECONDS)
with LoadMetrics {
- def this(
- parallelism: Int,
- threadFactory: ForkJoinPool.ForkJoinWorkerThreadFactory,
- unhandledExceptionHandler: Thread.UncaughtExceptionHandler) =
- this(parallelism, threadFactory, unhandledExceptionHandler, asyncMode =
true)
Review Comment:
it's an internal class so I think it is safe to remove the unused
constructors in a major release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
