raboof commented on code in PR #1968:
URL: https://github.com/apache/pekko/pull/1968#discussion_r2239159917
##########
project/JdkOptions.scala:
##########
@@ -19,89 +19,50 @@ import sbt.librarymanagement.VersionNumber
object JdkOptions extends AutoPlugin {
object autoImport {
- lazy val jdk8home = settingKey[String]("JDK 8 home. Only needs to be set
when it cannot be auto-detected by sbt")
lazy val targetSystemJdk = settingKey[Boolean](
- "Target the system JDK instead of building against JDK 8. When this is
enabled resulting artifacts may not work on JDK 8!")
+ "Target the system JDK instead of building against JDK 17. When this is
enabled resulting artifacts may not work on JDK 17!")
}
import autoImport._
lazy val specificationVersion: String =
sys.props("java.specification.version")
object JavaVersion {
- val majorVersion: Int = {
- // FIXME replace with Runtime.version() when we no longer support Java 8
- // See Oracle section 1.5.3 at:
- //
https://docs.oracle.com/javase/8/docs/technotes/guides/versioning/spec/versioning2.html
- val version = specificationVersion.split('.')
- val majorString =
- if (version(0) == "1") version(1) // Java 8 will be 1.8
- else version(0) // later will be 9, 10, 11 etc
- majorString.toInt
- }
+ val majorVersion: Int = java.lang.Runtime.version().feature()
Review Comment:
do we still need this int at all?
##########
.scala-steward.conf:
##########
@@ -1,17 +1,6 @@
updates.pin = [
- # Pin logback to v1.3.x because v1.4.x needs JDK11
Review Comment:
(maybe worth mentioning in the commit message that these pins are gone)
##########
project/JdkOptions.scala:
##########
@@ -19,89 +19,50 @@ import sbt.librarymanagement.VersionNumber
object JdkOptions extends AutoPlugin {
object autoImport {
- lazy val jdk8home = settingKey[String]("JDK 8 home. Only needs to be set
when it cannot be auto-detected by sbt")
lazy val targetSystemJdk = settingKey[Boolean](
Review Comment:
this whole concept might not be needed anymore either - it was introduced to
make development easier and not requiring 2 separate JDKs to be installed, but
that is not the case anymore.
##########
actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/LoggerClass.scala:
##########
@@ -26,6 +27,7 @@ import pekko.util.OptionVal
private[pekko] object LoggerClass {
// just to get access to the class context
+ @nowarn("msg=deprecated")
Review Comment:
what is deprecated here? can we replace it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
