pjfanning commented on code in PR #1919:
URL: https://github.com/apache/pekko/pull/1919#discussion_r2182508810
##########
persistence-typed/src/main/resources/reference.conf:
##########
@@ -47,6 +47,12 @@ pekko.persistence.typed {
# this can be changed by setting this to 'true' in which case the internal
logging is sent to
# the actor context logger.
use-context-logger-for-internal-logging = false
+
+ # Commands get stashed during persistence and un-stashed afterward, causing
functions to be called
+ # recursively if commands are read-only (i.e. do not cause any persistence).
This might cause a stack
+ # overflow in case there are many messages to unstash. Setting this to true
enables a fix that turns
+ # recursion into a plain cycle, thus preventing stack overflows
+ break-recursive-calls-when-unstashing-read-only-commands = false
Review Comment:
I'd prefer to default this to true. We would have to have a reasonable level
of confidence but if the unit tests pass. It is useful to have the config in
case someone finds an issue but in a 1.2.0 release, we can change the behaviour
in Pekko if it fixes issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
