pjfanning commented on code in PR #1919: URL: https://github.com/apache/pekko/pull/1919#discussion_r2161999633
########## persistence-typed-tests/src/test/scala/org/apache/pekko/persistence/typed/scaladsl/EventSourcedStashOverflowSpec.scala: ########## @@ -55,10 +55,11 @@ object EventSourcedStashOverflowSpec { SteppingInmemJournal.config("EventSourcedStashOverflow").withFallback(ConfigFactory.parseString(s""" pekko.persistence { typed { - stash-capacity = 1000 # enough to fail on stack size + stash-capacity = 20000 # enough to fail on stack size Review Comment: 2000 should be enough to reproduce the issue - if 20000 doesn't cause the test to run for too long then this is ok I would regard 10 seconds to be a long time for a unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org