pjfanning commented on code in PR #1892:
URL: https://github.com/apache/pekko/pull/1892#discussion_r2158883799
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/Children.scala:
##########
@@ -120,13 +120,13 @@ private[pekko] trait Children { this: ActorCell =>
refs.valuesIterator.foreach(_.stop())
}
- @nowarn @volatile private var _nextNameDoNotCallMeDirectly = 0L
+ private val _nextName = new java.util.concurrent.atomic.AtomicLong()
Review Comment:
even netty uses AtomicLongs
https://github.com/search?q=repo%3Anetty%2Fnetty%20atomiclong&type=code
It also uses the FieldUpdater in a few places but the Netty team seem to
believe that the FieldUpdater doesn't need to be used in every case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
