pjfanning commented on code in PR #137:
URL: https://github.com/apache/pekko-samples/pull/137#discussion_r2145648688
##########
pekko-sample-cluster-kubernetes-java/pom.xml:
##########
@@ -2,7 +2,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-sample-cluster-kubernetes-java</artifactId>
- <version>${version.number}</version>
+ <version>0.1.0</version>
Review Comment:
the CI build due to the old value - maybe mvn is now stricter about version
numbers based on tokens
```
+ mvn clean package docker:build
[INFO] Scanning for projects...
Error: ] Some problems were encountered while processing the POMs:
Warning: 'version' contains an expression but should be a constant. @
org.apache.pekko:pekko-sample-cluster-kubernetes-java:${version.number},
/home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml,
line 5, column 12
Error: 'version' must be a constant version but is
'${git.commit.time}-${git.commit.id.abbrev}'. @
org.apache.pekko:pekko-sample-cluster-kubernetes-java:${version.number},
/home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml,
line 5, column 12
@
Error: The build could not read 1 project -> [Help 1]
Error:
Error: The project
org.apache.pekko:pekko-sample-cluster-kubernetes-java:${git.commit.time}-${git.commit.id.abbrev}
(/home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml)
has 1 error
Error: 'version' must be a constant version but is
'${git.commit.time}-${git.commit.id.abbrev}'. @
org.apache.pekko:pekko-sample-cluster-kubernetes-java:${version.number},
/home/runner/work/pekko-samples/pekko-samples/pekko-sample-cluster-kubernetes-java/pom.xml,
line 5, column 12
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
