pjfanning commented on code in PR #1876:
URL: https://github.com/apache/pekko/pull/1876#discussion_r2113586144
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala:
##########
@@ -4628,15 +4628,18 @@ final class Flow[In, Out, Mat](delegate:
scaladsl.Flow[In, Out, Mat]) extends Gr
def aggregateWithBoundary[Agg, Emit](allocate:
java.util.function.Supplier[Agg],
aggregate: function.Function2[Agg, Out, Pair[Agg, Boolean]],
harvest: function.Function[Agg, Emit],
- emitOnTimer: Pair[java.util.function.Predicate[Agg],
java.time.Duration]): javadsl.Flow[In, Emit, Mat] =
+ emitOnTimer: Optional[Pair[java.util.function.Predicate[Agg],
java.time.Duration]])
Review Comment:
Is there any way that we could try method overloading? Keep the existing
aggregateWithBoundary function and add an extra aggregateWithBoundary function
that uses `Optional<Pair<???>>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
