He-Pin opened a new issue, #1875:
URL: https://github.com/apache/pekko/issues/1875

   ```scala
     @ApiMayChange
     def aggregateWithBoundary[Agg, Emit](allocate: 
java.util.function.Supplier[Agg],
         aggregate: function.Function2[Agg, Out, Pair[Agg, Boolean]],
         harvest: function.Function[Agg, Emit],
         emitOnTimer: Pair[java.util.function.Predicate[Agg], 
java.time.Duration]): javadsl.Source[Emit, Mat]
   ```
   
   I think it should be 
   ```scala 
     @ApiMayChange
     def aggregateWithBoundary[Agg, Emit](allocate: 
java.util.function.Supplier[Agg],
         aggregate: function.Function2[Agg, Out, Pair[Agg, Boolean]],
         harvest: function.Function[Agg, Emit],
         emitOnTimer: Optional[java.util.function.Predicate[Agg], 
java.time.Duration]]): javadsl.Source[Emit, Mat]
   ```
   
   The `emitOnTimer` should be an `Optional`.
   
   The API is marked as `@ApiMayChange`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to