raboof commented on PR #684: URL: https://github.com/apache/pekko-http/pull/684#issuecomment-2917582164
> > The naming clash between this and the other class named Trailer is somewhat annoying, and enclosing the class name in backticks actually doesnt make any difference, they would still collide, I am open to suggestions for a different name tho > > Is there anyway that > > https://github.com/apache/pekko-http/blob/887c2175a92c703cb3349450228aa101912b987c/http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/Trailer.scala#L22 > could be extended to support what you are doing here? Tbh while I'm sure we could make it work I think it would be extra confusing to use the same class for 'the header that announces the trailing headers' and 'the actual trailing headers'. > If there needs to be 2 separate classes, maybe we could call the new one `TrailerHeader`. It's a bit untidy but its easier to having 2 classes in the same jar with the same class name even if the package differs. There is precedent for having header classes that have a different name from the name of the header itself: for example, the `TE` class represents the `Transfer-Encoding` header, as `TransferEncoding` was already taken for the encodings 'themselves'. I wonder if we could make it even more descriptive, perhaps `TrailerAnnouncement`? But `TrailerHeader` works for me as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
