He-Pin commented on code in PR #1845: URL: https://github.com/apache/pekko/pull/1845#discussion_r2085817843
########## serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonObjectMapperProvider.scala: ########## @@ -512,6 +521,24 @@ class JacksonObjectMapperFactory { : immutable.Seq[(DeserializationFeature, Boolean)] = configuredFeatures + /** + * After construction of the `ObjectMapper` the configured enum features are applied to + * the mapper. These features can be amended programatically by overriding this method and + * return the features that are to be applied to the `ObjectMapper`. + * + * When implementing a `JacksonObjectMapperFactory` with Java the `immutable.Seq` can be + * created with [[pekko.japi.Util.immutableSeq]]. + * + * @param bindingName bindingName name of this `ObjectMapper` + * @param configuredFeatures the list of `DateTimeFeature` that were configured in + * `pekko.serialization.jackson3.enum-features` + */ + def overrideConfiguredEnumFeatures( + @unused bindingName: String, + configuredFeatures: immutable.Seq[(EnumFeature, Boolean)]) + : immutable.Seq[(EnumFeature, Boolean)] = + configuredFeatures Review Comment: then the java api should be a Pair -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org