raboof commented on issue #1835: URL: https://github.com/apache/pekko/issues/1835#issuecomment-2855896807
> * Why do `CurrentShardRegionState.unapply` and `ShardRegionStats.unapply` not extract the `failed` fields? The reason is that this class _used_ to be a case class when it only had a `shards` field. The `failed` field was introduced in 26c333b52c4. However, because we promise [binary compatibility](https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html), the signature of the `unapply` method was not allowed to change. For that reason, that commit turns the case class into a regular class with the 'old' unapply method. > * Why are `CurrentShardRegionState` and `ShardRegionStats` normal classes instead of case classes? Because if it had remained a case class, the `unapply` method signature would have changed, which would have broken binary compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
