mdedetrich opened a new pull request, #1060: URL: https://github.com/apache/pekko-connectors/pull/1060
Resolves: https://github.com/apache/pekko-connectors/issues/1054 This PR solves resumable upload for gcs when uploading an empty payload (i.e. zero bytes). Comments have been added explaining how the solution works, but in short a special sentinel value gets inserted in the `onComplete` of `statefulMap` where the chunks get calculated on the specific case that the state is empty (which means nothing is being processed, hence empty payload) and this sentinel value gets used/detected later when calculating the Content-Range header. A test has been added to confirm that this works, without this change the newly added test fails. I also rerun the entire test suite against a real GCS account to make sure there are no additional regressions. @He-Pin Would be good if you check this PR as you originally wrote some of the code being touched -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
