sndnv commented on PR #1035: URL: https://github.com/apache/pekko-connectors/pull/1035#issuecomment-2796894210
> @sndnv thank you for the large contribution. I haven't had a full look yet but it looks like it should be mergeable pretty much as is. Since it is a large change, would you be able to sign a CLA? See https://www.apache.org/licenses/contributor-agreements.html Signed; not sure what happens next but the email is sent. --- Since the agreement is to keep the module as-is for now, I'll add a few comments to the diff to make the review easier. Most of that code is a straight copy from `mqtt`, including the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
