pjfanning commented on code in PR #276: URL: https://github.com/apache/pekko-persistence-jdbc/pull/276#discussion_r2005412918
########## core/src/main/resources/schema/postgres/postgres-move-schema.sql: ########## @@ -0,0 +1,6 @@ +CREATE SCHEMA IF NOT EXISTS pekko; + +alter table event_journal set schema pekko; +alter table event_tag set schema pekko; Review Comment: * feels like we should not make the sql file changes after all * what we could do instead is use JDBC and derive the commands in code - what if someone chooses a non-empty schema name in their conf but the value wasn't 'pekko' - eg 'acme' ? * if we use JDBC, we should use preparedStatements because it is more dangerous to form SQL commands using string concats (SQL injection risks) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
