jypma commented on PR #1802: URL: https://github.com/apache/pekko/pull/1802#issuecomment-2768480326
I'm getting closer to a first well-connected base with things like resource safety, interruptability and time somewhat properly present. I think we should have a discussion on what to do with the interruptability of graphs, though: - Pekko's `KillSwitch` only has a `void` method to stop a graph. You won't know when it's actually stopped, unless you also have a `Sink` with a future that completes when the graph is actually dead. - Probably as a side result of this, `pekko-connectors-kafka` has its own [DrainingControl](https://github.com/apache/pekko-connectors-kafka/blob/5d1e083642498d83f63b6b573544b67499415a13/core/src/main/scala/org/apache/pekko/kafka/scaladsl/Consumer.scala#L109) concept, which does promise to shut down the graph (even cleanly). Is this something to discuss and look at now? I suppose it could be done later, by putting interruptability into a type class when creating a `GraphDef`, but it'd be nicer to stick to first-level concepts (like `KillSwitch`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
