mdedetrich commented on code in PR #1020:
URL: https://github.com/apache/pekko-connectors/pull/1020#discussion_r2020031289
##########
google-cloud-storage/src/test/scala/org/apache/pekko/stream/connectors/googlecloud/storage/impl/GoogleGCStorageStreamIntegrationSpec.scala:
##########
@@ -44,12 +44,9 @@ import scala.annotation.nowarn
*/
@DoNotDiscover
class GoogleGCStorageStreamIntegrationSpec extends
GCStorageStreamIntegrationSpec {
- @nowarn("msg=deprecated")
- def settings: GCStorageSettings = GCStorageSettings()
+ def settings: GoogleSettings = GoogleSettings()
override def bucket = "connectors"
override def rewriteBucket = "pekko-connectors-rewrite"
override def projectId = settings.projectId
- override def clientEmail = settings.clientEmail
Review Comment:
These methods aren't actually used anywhere which is why we can delete them
without problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
