raboof commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2717857440
> * Seems to work - tests pass
Very cool!
> * Big binary compatibility diffs for the generated classes
>
> Do we expect this to cause issues for users? I don't think they'll be
coding against the generated classes. This would be target at the 1.2.0 release
or if it's too big for there, we might need to consider delaying to 2.0.0.
>
> @raboof @kerr @Roiocam what do you think?
Indeed I typically don't expect those aspects of the generated classes to be
user-facing. Looking at
https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html
, while we haven't marked the generated code as 'internal API' as such, we do
reserve the right to do major updates of dependencies, and this generated code
is somewhat at the edge between being internal and being 'actually' part of the
dependency.
Perhaps we should do the following: merge this PR, and then see if we can
update Pekko gRPC to the Pekko snapshot without further changes (other than
perhaps declared dependencies). Since Pekko gRPC also heavily relies on
protobuf, if that builds without trouble, that's a strong indicator that the
change is reasonably safe and we can release it with 1.2.0. If Pekko gRPC needs
serious changes to work with that snapshot, then we should perhaps take this as
the opportunity to make the next version Pekko 2.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
