pjfanning commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1922757855
########## actor/src/main/scala/org/apache/pekko/dispatch/ThreadPoolBuilder.scala: ########## @@ -235,6 +235,18 @@ final case class MonitorableThreadFactory( } } +class MonitorableCarrierThreadFactory(name: String) + extends ForkJoinPool.ForkJoinWorkerThreadFactory { + private val counter = new AtomicLong(0L) + + def newThread(pool: ForkJoinPool): ForkJoinWorkerThread = { + val thread = VirtualThreadSupport.CarrieThreadFactory.newThread(pool) + // Name of the threads for the ForkJoinPool are not customizable. Change it here. + thread.setName(name + "-" + "CarrierThread" + "-" + counter.incrementAndGet()) + thread Review Comment: CarrieThreadFactory looks like a typo - maybe should be CarrierThreadFactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org