raboof commented on code in PR #1468:
URL: https://github.com/apache/pekko/pull/1468#discussion_r1921036375
##########
stream-testkit/src/main/mima-filters/1.1.1.backwards.excludes/pr-1468-override-timeout-stream-testkit.backwards.excludes:
##########
@@ -0,0 +1 @@
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.stream.testkit.scaladsl.StreamTestKit.assertNoChildren")
Review Comment:
When adding mima excludes, please add the reason why it is acceptable. In
this case, the reason might be we don't promise binary compatiblity for
-testkit artifacts
(https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html),
and that this method is `private[testkit]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
