NavidJalali commented on code in PR #651:
URL: https://github.com/apache/pekko-http/pull/651#discussion_r1916241159
##########
http-core/src/main/scala/org/apache/pekko/http/impl/engine/server/HttpServerBluePrint.scala:
##########
@@ -336,13 +336,14 @@ private[http] object HttpServerBluePrint {
openTimeouts = openTimeouts.tail
push(responseOut, grab(responseIn))
}
- override def onUpstreamFinish() = complete(responseOut)
- override def onUpstreamFailure(ex: Throwable) = fail(responseOut, ex)
+ override def onUpstreamFinish(): Unit = complete(responseOut)
+ override def onUpstreamFailure(ex: Throwable): Unit =
fail(responseOut, ex)
})
setHandler(responseOut,
new OutHandler {
- def onPull(): Unit = pull(responseIn)
- override def onDownstreamFinish() = cancel(responseIn)
+ def onPull():
+ Unit = pull(responseIn)
Review Comment:
oooo thanks for the tip!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
